fix(signals): classify PHP source files as code by luciferlive112116 · Pull Request #2845 · JSONbored/loopover

luciferlive112116 · 2026-07-03T22:31:16Z

Summary

isTestPath already recognizes PHP test files via the PHPUnit/PHPSpec SomethingTest(s)/Spec
class-suffix convention, but the sibling isCodeFile predicate was never given the matching php
source extension. A PHP source file was therefore classified as neither test nor code — the exact
failure isCodeFile's own comment says it guards against, and the same inconsistency that #2743
resolved for the JVM/C#/Swift set.

This adds php to isCodeFile in both synced copies (src/signals/local-branch.ts and its
kept-in-sync mirror in src/signals/engine.ts), so PHP source now counts as genuine code in the local
scorer's sourceLineCount, the missing_tests signal, classifyChangedFile, and the slop code-file
counts. A PaymentTest.php file stays a test (the !isTestFile guard still excludes it).

No linked issue: this is a small, self-evident correctness fix — one extension added to two
already-synced deterministic predicates, plus regression tests — mirroring #2743's JVM/C#/Swift
class-suffix alignment. It touches no public behavior, auth, schema, or deploy surface, so it fits the
repo's preferred (not required) linked-issue policy.

Scope

The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

If any required check was skipped, explain why:

Ran locally: git diff --check (clean), npm run typecheck (clean), and a focused test:coverage
over the tests that exercise both changed predicates — 194 related unit tests pass and both changed
lines (and both && branches) are covered, so codecov/patch is 100% on this diff.
Not run locally: the UI, MCP, workers, OpenAPI, actionlint, and audit jobs. This is a src/-only
deterministic path-classifier change that touches no UI/API/OpenAPI/MCP/DB/workflow surface, so those
jobs are no-ops for this diff; they run on CI (Linux). The |php addition only widens a regex
alternation and adds no new branch.

Safety

No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
API/OpenAPI/MCP behavior is updated and tested where needed.
UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

No UI, auth, CORS, API, or schema surface is touched — this is a pure, deterministic path-classifier
fix, so the auth/UI/OpenAPI boxes are N/A.
Regression tests added in test/unit/local-branch-file-classifiers.test.ts: PHP source
(UserController.php, PaymentGateway.php) → code; PHP class-suffix test (PaymentTest.php) → not
code.

codecov · 2026-07-03T22:37:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (d7787ef) to head (f7a9c49).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         256      256           
  Lines       28051    28051           
  Branches    10192    10192           
=======================================
  Hits        26990    26990           
  Misses        435      435           
  Partials      626      626

Files with missing lines	Coverage Δ
src/signals/engine.ts	`97.35% <100.00%> (ø)`
src/signals/local-branch.ts	`97.21% <100.00%> (ø)`

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

loopover-orb · 2026-07-03T23:13:46Z

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-03 23:11:22 UTC}

3 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a focused classifier parity fix: `php` is added to both synced `isCodeFile` predicates, and the local classifier tests now cover PHP source plus PHPUnit-style test suffix exclusion. The change matches the existing `isTestPath` PHP suffix rule and preserves the `!isTestFile` guard, so PHP application files now count as code while `PaymentTest.php` remains excluded. I do not see a blocking defect in the visible diff.

Nits — 3 non-blocking

nit: `test/unit/test-evidence.test.ts` still names the suffix-convention coverage as JVM / C# / Swift and has no direct PHP assertion, so the upstream `isTestPath` PHP contract this PR relies on is less explicitly pinned than the local `isCodeFile` wrapper.
Add direct PHP assertions beside the existing suffix-convention checks in `test/unit/test-evidence.test.ts`, for example `WidgetTest.php` true and `Latest.php` false, so future edits cannot silently break the source/test split this PR is aligning with.
Tighten the comment in `src/signals/local-branch.ts:1267` to avoid calling PHP part of the JVM/.NET/Swift set; something like “cs/swift/groovy/php align source extensions with the class-suffix test conventions” is clearer.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ No-issue rationale	PR body explains why no issue is linked.
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (no linked issue context).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 65 registered-repo PR(s), 22 merged, 19 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	luciferlive112116; Gittensor profile; 65 PR(s), 19 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

Author: luciferlive112116
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository registration is not available in the local Gittensory cache.
Public profile languages: JavaScript, MDX, Python, Rust, TypeScript
Official Gittensor activity: 65 PR(s), 19 issue(s).
PR-specific overlap: none found.

Contributor next steps

Await review-lane availability.
Refresh registry data or choose a registered active repo.
Link the issue being solved, or explicitly explain why this is a no-issue PR.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

Re-run Gittensory review

loopover-orb

Gittensory approves — the gate is satisfied and CI is green.

fix(signals): classify PHP source files as code

f7a9c49

luciferlive112116 requested a review from JSONbored as a code owner July 3, 2026 22:31

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 3, 2026

loopover-orb Bot added the gittensor label Jul 3, 2026

loopover-orb Bot approved these changes Jul 3, 2026

View reviewed changes

loopover-orb Bot merged commit d141364 into JSONbored:main Jul 3, 2026
9 checks passed

This was referenced Jul 9, 2026

MCP release due: 0.7.0 RealDiligent/gittensory#6

Open

MCP release due: 1.0.0 joaovictor91123/gittensory#2

Open

Navigation Menu

Uh oh!

fix(signals): classify PHP source files as code - #2845

fix(signals): classify PHP source files as code#2845
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:fix/signals-classify-php-source-as-code

luciferlive112116 commented Jul 3, 2026

Uh oh!

codecov Bot commented Jul 3, 2026 •

edited

Loading

Uh oh!

loopover-orb Bot commented Jul 3, 2026 •

edited

Loading

⏸️ Gittensory review result - manual review recommended

Uh oh!

loopover-orb Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

luciferlive112116 commented Jul 3, 2026

Summary

Scope

Validation

Safety

Notes

Uh oh!

codecov Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

loopover-orb Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏸️ Gittensory review result - manual review recommended

Uh oh!

loopover-orb Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov Bot commented Jul 3, 2026 •

edited

Loading

loopover-orb Bot commented Jul 3, 2026 •

edited

Loading